Implementing restart_async for EventMachine#1
Merged
dblock merged 2 commits intodblock:em-celluloid-pingfrom Dec 16, 2018
Merged
Implementing restart_async for EventMachine#1dblock merged 2 commits intodblock:em-celluloid-pingfrom
dblock merged 2 commits intodblock:em-celluloid-pingfrom
Conversation
added 2 commits
December 15, 2018 04:46
…so that EventMachine continues running until disconnect! is called.
Owner
|
Thanks, lets see how it merges upstream ... |
dblock
added a commit
that referenced
this pull request
Aug 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've implemented EventMachine's
restart_asyncmethod to kick off the client's run_loop again. I also removed the call to stop EventMachine onclosebecause we only want to completely close whendisconnect!is called.