custom non blocking reader#322
Merged
Merged
Conversation
kraftp
reviewed
Mar 24, 2026
Member
kraftp
left a comment
kraftp
left a comment
There was a problem hiding this comment.
Just to make sure, we've run all the Conductor tests (in the Conductor repo) against this and it works?
Collaborator
Author
running them locally now |
kraftp
approved these changes
Mar 24, 2026
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous import workflow streaming approach used PipedReader, which would block the web socket when receive many chunks of a single message (like say a large import). Replaced PipedReader with a custom reader that stores all the received text chunks in a queue w/o blocking the web socket thread