Skip to content

Conversation

@aschereT
Copy link
Contributor

  1. Use multistage Dockerfile. This allows the final image to avoid including build dependencies such as GCC
  2. Include pg_jobmon, an optional dependency of pg_partman

The size of the final image for PostgreSQL 17 and pg_partman 5 is reduced from 630 MB to 374 MB (arm64).

@aschereT aschereT marked this pull request as ready for review May 22, 2025 21:32
@aschereT aschereT requested a review from jschirrmacher as a code owner May 22, 2025 21:32
@Morl99 Morl99 requested review from Morl99 and removed request for jschirrmacher May 23, 2025 21:26
Copy link
Contributor

@Morl99 Morl99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, using Multi Stage is a great idea. And since pg_jobmom is listed as a recommended extension on the pg_partman docs, I see no reason to not include it in this image.

I just have a single request to change all the ARG values so that they only appear once in the Dockerfile.

And please add a line to the Readme that pg_jobmon is included.

@Morl99
Copy link
Contributor

Morl99 commented May 23, 2025

One more thing, we need to have #25 in mind and maybe even fix it before merging this ;-) Alternatively we can change the base branch and pull the code into a staging branch to run the build.

@Morl99 Morl99 changed the base branch from main to integrate May 26, 2025 18:38
@Morl99
Copy link
Contributor

Morl99 commented May 26, 2025

Since I cannot find an easy fix for #24 and I do not have the time to play around with different permissions/tokens, I will merge this into another branch and the create a separate MR to merge this into main, where the workflows will run.

Thank you @aschereT for the contribution.

@Morl99 Morl99 merged commit 5fa3bec into dbsystel:integrate May 26, 2025
0 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants