Conversation
dcarbone
commented
Oct 25, 2025
dcarbone
commented
- Remove dependency on curl-plus package
- Misc 8.2+ updates
- Cleanup
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the SoapPlus library by removing the curl-plus dependency and updating to PHP 8.2+ standards. The changes include replacing the CurlPlusClient wrapper with native PHP curl functions, updating PHPUnit configuration to version 12.4, and refactoring the test suite to use modern PHPUnit practices.
Key Changes:
- Removed dependency on the curl-plus package, implementing direct curl usage
- Updated minimum PHP version requirement from 8.0 to 8.2
- Modernized PHPUnit configuration and tests from version 9.3 to 12.4
Reviewed Changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/SoapPlus/SoapClientPlusTest.php | Removed old test file from nested directory |
| tests/SoapClientPlusTest.php | Added modernized test suite with namespace support and updated test methods |
| src/SoapClientPlus.php | Replaced CurlPlusClient usage with native curl functions and removed deprecated methods |
| phpunit.xml.dist | Updated PHPUnit schema to version 12.4 and reorganized configuration structure |
| phpunit.local.xml | Updated PHPUnit schema to version 12.4 with coverage configuration |
| composer.json | Updated PHP requirement to 8.2+, removed curl-plus dependency, added dev autoload |
| .github/workflows/tests.yaml | Updated PHP versions in test matrix and added explicit permissions configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 8 out of 10 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 8 out of 10 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
