Skip to content

fix: add process-level uncaughtException and unhandledRejection handlers#124

Merged
dcccrypto merged 1 commit intodcccrypto:mainfrom
0x-SquidSol:fix/add-global-error-handlers
Apr 7, 2026
Merged

fix: add process-level uncaughtException and unhandledRejection handlers#124
dcccrypto merged 1 commit intodcccrypto:mainfrom
0x-SquidSol:fix/add-global-error-handlers

Conversation

@0x-SquidSol
Copy link
Copy Markdown
Contributor

Summary

  • The application had SIGTERM/SIGINT handlers but no handlers for uncaughtException or unhandledRejection, causing silent crashes without logging or cleanup
  • Fix: Both handlers now log the error and call the existing shutdown() function, which handles Sentry flush, WebSocket cleanup, HTTP server close, and has a 10s force-exit timeout

Files Changed

  • src/index.ts — Added 2 process event handlers (8 lines)

Test plan

  • All 189 existing tests pass
  • TypeScript compiles clean (tsc --noEmit)
  • Verified no infinite loop risk (shutdown has try/catch + force-exit timeout)
  • Verified no duplicate handler conflicts with existing SIGTERM/SIGINT

🤖 Generated with Claude Code

The application had SIGTERM/SIGINT handlers but no handlers for uncaught
exceptions or unhandled promise rejections, causing silent crashes without
logging or cleanup.

Both handlers now log the error and call the existing shutdown() function
for graceful cleanup (Sentry flush, WS close, HTTP server close) with
the existing 10s force-exit timeout as a safety net.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 7, 2026

Warning

Rate limit exceeded

@0x-SquidSol has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 24 minutes and 20 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 24 minutes and 20 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c25806af-47e6-4e89-bfb1-88d617d95739

📥 Commits

Reviewing files that changed from the base of the PR and between e9c72c9 and 3d70267.

📒 Files selected for processing (1)
  • src/index.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dcccrypto
Copy link
Copy Markdown
Owner

Sentinel security review — MERGE

Without uncaughtException / unhandledRejection handlers, any unhandled async throw would kill the process silently — no Sentry flush, no WebSocket teardown, no HTTP server close. Both handlers now route through the existing shutdown() function which has a 10-second force-exit timeout preventing infinite loops. Change is 8 lines in src/index.ts with no new logic surface.

No blocking findings. Security APPROVED.

@dcccrypto dcccrypto merged commit 8a720b8 into dcccrypto:main Apr 7, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants