Conversation
The `Mut::new` constructor was previously creating a `ptr::NonNull` from a temporary `HashSet` created on the stack. This resulted in a dangling pointer that would cause undefined behavior when accessed during dereferencing or when calling `get_mut`. The `modified` field in `Mut` is now an `Option`. When created via `Mut::new`, it is set to `None`, and modification tracking is skipped. `IterMut` continues to provide the pointer to its internal tracking set to ensure that modifications via iterator are still correctly captured. Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Mut::new_untrackedconstructor was previously creating aptr::NonNullfrom a temporaryHashSetcreated on the stack. This resulted in a dangling pointer that would cause undefined behavior when accessed during dereferencing or when callingget_mut.The
modifiedfield inMutis now anOption. When created viaMut::new_untracked, it is set toNone, and modification tracking is skipped.IterMutcontinues to provide the pointer to its internal tracking set to ensure that modifications via iterator are still correctly captured.