Conversation
Split conversation `events.json` into separate `base_config.json` and `events.json` files. The base config is currently packed as a synthetic first element in the events array, making `events.json` difficult to inspect — opening it in an editor requires scrolling past hundreds of lines of config JSON to reach actual events. The new layout stores the `PartialAppConfig` snapshot in `base_config.json` and keeps only `InternalEvent` entries in `events.json`. Backward compatibility is handled transparently at load time by detecting the old format and migrating on next persist. Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split conversation
events.jsoninto separatebase_config.jsonandevents.jsonfiles. The base config is currently packed as a synthetic first element in the events array, makingevents.jsondifficult to inspect — opening it in an editor requires scrolling past hundreds of lines of config JSON to reach actual events.The new layout stores the
PartialAppConfigsnapshot inbase_config.jsonand keeps onlyInternalEvententries inevents.json. Backward compatibility is handled transparently at load time by detecting the old format and migrating on next persist.