Conversation
The Windows test matrix entry was missing a `cache_suffix`, causing it
to share the same toolchain and `rust-cache` keys as Linux/macOS builds.
Since caches can only be accessed by one runner at a time, this would
cause one of the two test jobs to ignore the cache.
Added `cache_suffix: "-windows"` to the Windows matrix entry and
threaded `${{ matrix.name_suffix }}` into both the toolchain and
`rust-cache` keys so each OS gets its own isolated cache.
Also added `.github/` and `justfile` to `.ignore` so that file- search
tools respecting this whitelist (e.g. ripgrep) can include CI workflows
and the justfile in project-wide searches.
Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows test matrix entry was missing a
cache_suffix, causing it to share the same toolchain andrust-cachekeys as Linux/macOS builds. Since caches can only be accessed by one runner at a time, this would cause one of the two test jobs to ignore the cache.Added
cache_suffix: "-windows"to the Windows matrix entry and threaded${{ matrix.name_suffix }}into both the toolchain andrust-cachekeys so each OS gets its own isolated cache.Also added
.github/andjustfileto.ignoreso that file- search tools respecting this whitelist (e.g. ripgrep) can include CI workflows and the justfile in project-wide searches.