Conversation
Three small improvements to how `jp` identifies itself: - The git hash from `rev-parse` includes a trailing newline, which cut off the `LONG_VERSION`. Trimming the output fixes the malformed version string. - The long version string now carries a `v` prefix, making it consistent with conventional version formatting (e.g. `v0.1.0-abc1234 (2025-05-27)`). - The CLI command is now explicitly named `jp`, ensuring help output and error messages always refer to the binary by its correct name regardless of how it is invoked. Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small improvements to how
jpidentifies itself:The git hash from
rev-parseincludes a trailing newline, which cut off theLONG_VERSION. Trimming the output fixes the malformed version string.The long version string now carries a
vprefix, making it consistent with conventional version formatting (e.g.v0.1.0-abc1234 (2025-05-27)).The CLI command is now explicitly named
jp, ensuring help output and error messages always refer to the binary by its correct name regardless of how it is invoked.