Conversation
When fetching a web page section by anchor, the anchor `id` is sometimes placed on a child element inside a heading tag rather than on the heading itself. Previously `extract_anchor_html` only recognised the target as a heading if the matched element was directly a heading tag, causing it to fall back to returning just that inner element's HTML instead of the full heading section. Now, when the matched element is not itself a heading, the code walks up its ancestor chain via `find_heading_ancestor`. If a heading ancestor is found it is used as the section root, so the correct section content (everything up to the next same-or-higher level heading) is returned. Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When fetching a web page section by anchor, the anchor
idis sometimes placed on a child element inside a heading tag rather than on the heading itself. Previouslyextract_anchor_htmlonly recognised the target as a heading if the matched element was directly a heading tag, causing it to fall back to returning just that inner element's HTML instead of the full heading section.Now, when the matched element is not itself a heading, the code walks up its ancestor chain via
find_heading_ancestor. If a heading ancestor is found it is used as the section root, so the correct section content (everything up to the next same-or-higher level heading) is returned.