Conversation
Previously, `session_active_conversation` and `session_previous_conversation` could return stale IDs for conversations no longer in the workspace index. Both methods now filter against the index, returning `None` when the referenced conversation is gone. `cleanup_stale_files` gains a second pass: after deciding whether to remove an entire session file, it now prunes individual history entries that reference deleted conversations. An entry is removed when the conversation is absent from disk and no other process holds its write lock — the lock check guards against a mid-persist race where a conversation is being written but not yet indexed. To support the lock probe, `jp_storage` gains `is_conversation_locked`, which checks an existing lock file without creating one. The path resolution logic is extracted into a shared `lock_file_path` helper. Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
session_active_conversationandsession_previous_conversationcould return stale IDs for conversations no longer in the workspace index. Both methods now filter against the index, returningNonewhen the referenced conversation is gone.cleanup_stale_filesgains a second pass: after deciding whether to remove an entire session file, it now prunes individual history entries that reference deleted conversations. An entry is removed when the conversation is absent from disk and no other process holds its write lock — the lock check guards against a mid-persist race where a conversation is being written but not yet indexed.To support the lock probe,
jp_storagegainsis_conversation_locked, which checks an existing lock file without creating one. The path resolution logic is extracted into a sharedlock_file_pathhelper.