Conversation
When a turn is interrupted (e.g. the `ChatRequest` is popped before streaming begins), a lone `TurnStart` is left at the end of the stream. Previously, `sanitize()` did not account for this case, meaning the orphaned `TurnStart` would persist and corrupt the turn index after re-normalization. `trim_trailing_empty_turn` is now called as part of `sanitize()`, cleaning up any trailing `TurnStart` that has no following events before `normalize_turn_starts` runs. Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a turn is interrupted (e.g. the
ChatRequestis popped before streaming begins), a loneTurnStartis left at the end of the stream. Previously,sanitize()did not account for this case, meaning the orphanedTurnStartwould persist and corrupt the turn index after re-normalization.trim_trailing_empty_turnis now called as part ofsanitize(), cleaning up any trailingTurnStartthat has no following events beforenormalize_turn_startsruns.