Conversation
When the user presses Ctrl+C, Unix sends SIGINT to all processes in JP's process group, including any tool subprocesses. This caused tool executions to be killed by the signal rather than being cleanly managed through the cancellation token. Two changes address this: `process_group(0)` isolates the child into its own process group on Unix, so terminal signals no longer reach it. `kill_on_drop(true)` ensures the child is still cleaned up when the tokio task is aborted on cancellation, preventing orphaned processes. Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the user presses Ctrl+C, Unix sends SIGINT to all processes in JP's process group, including any tool subprocesses. This caused tool executions to be killed by the signal rather than being cleanly managed through the cancellation token.
Two changes address this:
process_group(0)isolates the child into its own process group on Unix, so terminal signals no longer reach it.kill_on_drop(true)ensures the child is still cleaned up when the tokio task is aborted on cancellation, preventing orphaned processes.