Conversation
When `self.prefix` contained fewer than 2 bytes, the slice `&self.prefix.as_bytes()[self.prefix.len() - 2..]` would underflow, causing a panic at runtime. Replace the bare subtraction with `saturating_sub(2)` so that a prefix of 0 or 1 bytes is handled gracefully — the window is seeded with whatever bytes are available rather than wrapping to `usize::MAX`. A regression test for the 1-byte case and a sanity check for the empty prefix case are added in `writer_tests.rs`. Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
self.prefixcontained fewer than 2 bytes, the slice&self.prefix.as_bytes()[self.prefix.len() - 2..]would underflow, causing a panic at runtime.Replace the bare subtraction with
saturating_sub(2)so that a prefix of 0 or 1 bytes is handled gracefully — the window is seeded with whatever bytes are available rather than wrapping tousize::MAX.A regression test for the 1-byte case and a sanity check for the empty prefix case are added in
writer_tests.rs.