Conversation
Architecture and software engineering knowledge sections were duplicated
inline in both the `architect` and `dev` personas. This extracts them
into dedicated knowledge files (`architecture.toml` and
`software-engineering.toml`) that can be reused across personas via
`extends`.
A new `rfd-reviewer` persona is added for reviewing RFD documents. It
combines architecture and software engineering knowledge with research
skills (file reading, GitHub issues/PRs, git history) to provide
grounded, evidence-backed feedback on RFDs.
A matching `just rfd-review` command is added to the justfile. It
accepts a permanent RFD number (`41`, `041`) or a draft ID (`D01`),
resolves the file path, and invokes `jp query` with the `rfd-reviewer`
persona and the RFD file attached.
The Rust development skill (`rust-development.toml`) is expanded with
explicit, example-backed code style rules covering import placement,
qualified path avoidance, `?`-operator usage, expression-oriented style,
match arm patterns, and derive attribute grouping.
Additional changes:
- Shell functions in the justfile now use `${2-}` instead of `$2` to
avoid unbound variable errors under `set -eu`.
- `_coverage-setup` installs `cargo-llvm-cov` separately without
`--only-signed`, working around its disabled QuickInstall strategy.
- Stager persona reasoning effort changed from `auto` to `medium`.
Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Architecture and software engineering knowledge sections were duplicated inline in both the
architectanddevpersonas. This extracts them into dedicated knowledge files (architecture.tomlandsoftware-engineering.toml) that can be reused across personas viaextends.A new
rfd-reviewerpersona is added for reviewing RFD documents. It combines architecture and software engineering knowledge with research skills (file reading, GitHub issues/PRs, git history) to provide grounded, evidence-backed feedback on RFDs.A matching
just rfd-reviewcommand is added to the justfile. It accepts a permanent RFD number (41,041) or a draft ID (D01), resolves the file path, and invokesjp querywith therfd-reviewerpersona and the RFD file attached.The Rust development skill (
rust-development.toml) is expanded with explicit, example-backed code style rules covering import placement, qualified path avoidance,?-operator usage, expression-oriented style, match arm patterns, and derive attribute grouping.Additional changes:
${2-}instead of$2to avoid unbound variable errors underset -eu._coverage-setupinstallscargo-llvm-covseparately without--only-signed, working around its disabled QuickInstall strategy.autotomedium.