Conversation
During workspace sanitization, invalid conversation directories are normally trashed. However, this creates a race condition when two processes are running concurrently: process A creates a conversation directory (e.g. for `QUERY_MESSAGE.md` while the editor is open) but hasn't persisted `metadata.json` yet, and process B's sanitization deletes it because it looks invalid. To fix this, a new `is_conversation_locked` method is added to `Storage`, which returns `true` if a live (non-orphaned) lock file exists for a given conversation ID. During sanitization, any invalid conversation directory that is currently locked is skipped with a `debug`-level log entry instead of being trashed. Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During workspace sanitization, invalid conversation directories are normally trashed. However, this creates a race condition when two processes are running concurrently: process A creates a conversation directory (e.g. for
QUERY_MESSAGE.mdwhile the editor is open) but hasn't persistedmetadata.jsonyet, and process B's sanitization deletes it because it looks invalid.To fix this, a new
is_conversation_lockedmethod is added toStorage, which returnstrueif a live (non-orphaned) lock file exists for a given conversation ID. During sanitization, any invalid conversation directory that is currently locked is skipped with adebug-level log entry instead of being trashed.