Skip to content

fix(md): Remove <!-- end list --> from terminal output#583

Merged
JeanMertz merged 1 commit intomainfrom
prr149
Apr 28, 2026
Merged

fix(md): Remove <!-- end list --> from terminal output#583
JeanMertz merged 1 commit intomainfrom
prr149

Conversation

@JeanMertz
Copy link
Copy Markdown
Collaborator

comrak's CommonMark serializer emits <!-- end list --> between adjacent lists and before indented code blocks as a round-trip hint — it helps the serializer's own output be re-parsed without ambiguity. The terminal renderer has no such obligation; its output is never fed back into a markdown parser, so the marker is pure visual noise.

Removed the block that conditionally wrote the marker and changed format_list from returning fmt::Result to returning (), since it no longer performs any fallible writes.

comrak's CommonMark serializer emits `<!-- end list -->` between
adjacent lists and before indented code blocks as a round-trip hint — it
helps the serializer's own output be re-parsed without ambiguity. The
terminal renderer has no such obligation; its output is never fed back
into a markdown parser, so the marker is pure visual noise.

Removed the block that conditionally wrote the marker and changed
`format_list` from returning `fmt::Result` to returning `()`, since it
no longer performs any fallible writes.

Signed-off-by: Jean Mertz <git@jeanmertz.com>
@JeanMertz JeanMertz merged commit b7ca244 into main Apr 28, 2026
18 of 23 checks passed
@JeanMertz JeanMertz deleted the prr149 branch April 28, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant