Conversation
Some LLMs emit explicit `null` values for optional parameters that were not provided by the caller. Previously, `opt` would attempt to deserialize `null` via `req`, which could produce a type error instead of cleanly returning `None`. The fix matches on the raw `Value` before delegating to `req`, returning `Ok(None)` for both a missing key and an explicit `Value::Null`. A dedicated test covers all three cases: explicit null, a present value, and a fully absent key. Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some LLMs emit explicit
nullvalues for optional parameters that were not provided by the caller. Previously,optwould attempt to deserializenullviareq, which could produce a type error instead of cleanly returningNone.The fix matches on the raw
Valuebefore delegating toreq, returningOk(None)for both a missing key and an explicitValue::Null. A dedicated test covers all three cases: explicit null, a present value, and a fully absent key.