Conversation
The `just pr-triage NNN` command opens a structured triage session for a pull request's review comments. It attaches the PR's diff and reviews, routes to a new `pr-triager` persona, and resumes an existing `pr-triage:NNN` conversation when one is found — keeping context across review cycles without rediscovering the codebase. Replying to review threads from the triager requires three supporting pieces. `jp_github`'s `PullsHandler` gains two new GraphQL methods: `fetch_thread_id_for_comment` maps a REST comment ID to the thread's GraphQL node ID (needed by the reply mutation), and `add_review_thread_reply` calls `addPullRequestReviewThreadReply` to queue the reply in the caller's pending review. On top of those, a new `github_pr_review_add_reply` tool exposes the capability with a parameter formatter that re-fetches the parent comment so the user sees a fresh preview before approving the post. The `gh:pull/N/reviews` attachment now surfaces each comment's REST ID as `id=<n>` in the rendered output, so the triager can pass it directly as `comment_id`. Pending reviews also show the author's real login instead of the generic "you" — the old label was misleading when a different model triages the same PR under the same credentials. The `rfd-feedback` persona is renamed to `rfd-triager` for consistency with the new naming convention; its instructions are otherwise unchanged. Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
just pr-triage NNNcommand opens a structured triage session for a pull request's review comments. It attaches the PR's diff and reviews, routes to a newpr-triagerpersona, and resumes an existingpr-triage:NNNconversation when one is found — keeping context across review cycles without rediscovering the codebase.Replying to review threads from the triager requires three supporting pieces.
jp_github'sPullsHandlergains two new GraphQL methods:fetch_thread_id_for_commentmaps a REST comment ID to the thread's GraphQL node ID (needed by the reply mutation), andadd_review_thread_replycallsaddPullRequestReviewThreadReplyto queue the reply in the caller's pending review. On top of those, a newgithub_pr_review_add_replytool exposes the capability with a parameter formatter that re-fetches the parent comment so the user sees a fresh preview before approving the post.The
gh:pull/N/reviewsattachment now surfaces each comment's REST ID asid=<n>in the rendered output, so the triager can pass it directly ascomment_id. Pending reviews also show the author's real login instead of the generic "you" — the old label was misleading when a different model triages the same PR under the same credentials.The
rfd-feedbackpersona is renamed torfd-triagerfor consistency with the new naming convention; its instructions are otherwise unchanged.