Conversation
JeanMertz
changed the title
Previously, the `[Showing ...]` note was written before the fenced diff block, which meant the note appeared at the top of the output. The output now places the fenced diff block first and appends the note after it, which reads more naturally when scanning the result. The test is updated accordingly: rather than asserting the output ends with the closing fence, it asserts both the fence and the note are present in the correct relative order. Signed-off-by: Jean Mertz <git@jeanmertz.com>
Remove the unused `-I`/`--no-inherit` global CLI flag from `jp_cli`. Fix a stale env var name in the test suite: `JP_GLOBAL_CONFIG_FILE` → `JP_GLOBAL_CONFIG_DIR`. Add a new `docs/architecture/ubiquitous-language.md` — a canonical glossary of JP's domain vocabulary (Workspace, Conversation, Thread, Turn, Attachment, Inquiry, Provider, RFD, Tool Call). This gives both human and AI contributors a shared, rigorous reference to avoid term drift across code, docs, and commit messages. Add a `rfd-triage` recipe to the justfile for triaging reviewer feedback on an RFD. Accepts the RFD number (permanent or draft), a mode (`new`/`continue`), and the conversation ID of the review run to pull feedback from, then invokes the `rfd-triager` persona. Also include minor housekeeping: ignore `.jp/local-conversations/`, include `r.num` in the RFD index search filter, switch the `pr-reviewer` persona to `gpt` with `max` reasoning effort, add a "no redundant type annotations" rule to the Rust development skill, and reorder a few dependency entries for consistency. Signed-off-by: Jean Mertz <git@jeanmertz.com>
…t IDs Two new draft RFDs under `docs/rfd/drafts/`: `D20-project-workspace-and-storage.md` addresses the overloaded "workspace" term by introducing three named concepts: Project (the directory the user works in), Workspace (the logical JP context), and Workspace storage (the physical `.jp/` location). It also formalises a gitfile-style `.jp` marker file for placing storage outside the project tree, and makes `config_load_paths` resolution symmetric across all three config roots — resolving the parked drawback from RFD 035. `D20-stable-event-identifiers.md` proposes adding an `EventId` field to `ConversationEvent` so that events carry stable, opaque identifiers unique within their stream. This removes the hazards of position-based references when users manually edit `events.json` (delete, reorder, copy), and provides the primitive needed by several future features (compaction, sub-agent workflows, plugin event subscriptions). Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two new draft RFDs under
docs/rfd/drafts/:D20-project-workspace-and-storage.mdaddresses the overloaded "workspace" term by introducing three named concepts: Project (the directory the user works in), Workspace (the logical JP context), and Workspace storage (the physical.jp/location). It also formalises a gitfile-style.jpmarker file for placing storage outside the project tree, and makesconfig_load_pathsresolution symmetric across all three config roots — resolving the parked drawback from RFD 035.D20-stable-event-identifiers.mdproposes adding anEventIdfield toConversationEventso that events carry stable, opaque identifiers unique within their stream. This removes the hazards of position-based references when users manually editevents.json(delete, reorder, copy), and provides the primitive needed by several future features (compaction, sub-agent workflows, plugin event subscriptions).