Conversation
The `rfd-review`, and `rfd-triage` commands have been reworked to support iterative review cycles without losing conversation context. A new `rfd-apply` command is introduced to apply triage verdicts back to the RFD file. Two private helpers centralise repeated logic that was previously copy-pasted across commands. `_resolve-conversation TITLE` looks up an active conversation by title and prompts the user to continue, archive-and-restart, or quit, emitting a tagged token the caller dispatches on. `_bear-note TAG` resolves a Bear note by tag and prompts when none is found, emitting FOUND/EDIT/CONTINUE/QUIT. Both `pr-review` and `pr-triage` are updated to use `_resolve-conversation` in place of their own inline lookup-and-prompt blocks. `rfd-review` now titles its conversation `rfd-review:<id>`, supports resuming that conversation across cycles, and — in continuation mode — automatically attaches the latest user/assistant turn from the sibling `rfd-triage:<id>` conversation so the reviewer can engage with the triager's response from the prior round. Bear notes tagged `rfd/<id>/review` are attached when found. `rfd-triage` drops the positional `MODE` and `CONVO` arguments. It now discovers the sibling `rfd-review:<id>` conversation automatically (failing fast if none exists), titles its own conversation `rfd-triage:<id>`, and supports continuation via `_resolve-conversation`. Bear notes tagged `rfd/<id>/triage` are attached when found. `rfd-apply` is a new command that resumes the `rfd-triage:<id>` conversation with the dev persona, re-attaches the current RFD file, and instructs the model to apply only the triaged verdicts. Bear notes tagged `rfd/<id>/apply` are attached when found. The rfd-reviewer persona is updated to handle continuation rounds: it now knows to engage with the `jp://` triage attachment, acknowledge resolved concerns, and re-raise unresolved ones rather than redoing critique already applied. Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
rfd-review, andrfd-triagecommands have been reworked tosupport iterative review cycles without losing conversation context. A
new
rfd-applycommand is introduced to apply triage verdicts back tothe RFD file.
Two private helpers centralise repeated logic that was previously
copy-pasted across commands.
_resolve-conversation TITLElooks up anactive conversation by title and prompts the user to continue,
archive-and-restart, or quit, emitting a tagged token the caller
dispatches on.
_bear-note TAGresolves a Bear note by tag and promptswhen none is found, emitting FOUND/EDIT/CONTINUE/QUIT. Both
pr-reviewand
pr-triageare updated to use_resolve-conversationin place oftheir own inline lookup-and-prompt blocks.
rfd-reviewnow titles its conversationrfd-review:<id>, supportsresuming that conversation across cycles, and — in continuation mode —
automatically attaches the latest user/assistant turn from the sibling
rfd-triage:<id>conversation so the reviewer can engage with thetriager's response from the prior round. Bear notes tagged
rfd/<id>/revieware attached when found.rfd-triagedrops the positionalMODEandCONVOarguments. It nowdiscovers the sibling
rfd-review:<id>conversation automatically(failing fast if none exists), titles its own conversation
rfd-triage:<id>, and supports continuation via_resolve-conversation. Bear notes taggedrfd/<id>/triageareattached when found.
rfd-applyis a new command that resumes therfd-triage:<id>conversation with the dev persona, re-attaches the current RFD file, and
instructs the model to apply only the triaged verdicts. Bear notes
tagged
rfd/<id>/applyare attached when found.The rfd-reviewer persona is updated to handle continuation rounds: it
now knows to engage with the
jp://triage attachment, acknowledgeresolved concerns, and re-raise unresolved ones rather than redoing
critique already applied.