Skip to content

build(tools): Overhaul RFD justfile workflow for multi-cycle reviews#627

Merged
JeanMertz merged 1 commit into
mainfrom
prr194
May 11, 2026
Merged

build(tools): Overhaul RFD justfile workflow for multi-cycle reviews#627
JeanMertz merged 1 commit into
mainfrom
prr194

Conversation

@JeanMertz
Copy link
Copy Markdown
Collaborator

The rfd-review, and rfd-triage commands have been reworked to
support iterative review cycles without losing conversation context. A
new rfd-apply command is introduced to apply triage verdicts back to
the RFD file.

Two private helpers centralise repeated logic that was previously
copy-pasted across commands. _resolve-conversation TITLE looks up an
active conversation by title and prompts the user to continue,
archive-and-restart, or quit, emitting a tagged token the caller
dispatches on. _bear-note TAG resolves a Bear note by tag and prompts
when none is found, emitting FOUND/EDIT/CONTINUE/QUIT. Both pr-review
and pr-triage are updated to use _resolve-conversation in place of
their own inline lookup-and-prompt blocks.

rfd-review now titles its conversation rfd-review:<id>, supports
resuming that conversation across cycles, and — in continuation mode —
automatically attaches the latest user/assistant turn from the sibling
rfd-triage:<id> conversation so the reviewer can engage with the
triager's response from the prior round. Bear notes tagged
rfd/<id>/review are attached when found.

rfd-triage drops the positional MODE and CONVO arguments. It now
discovers the sibling rfd-review:<id> conversation automatically
(failing fast if none exists), titles its own conversation
rfd-triage:<id>, and supports continuation via
_resolve-conversation. Bear notes tagged rfd/<id>/triage are
attached when found.

rfd-apply is a new command that resumes the rfd-triage:<id>
conversation with the dev persona, re-attaches the current RFD file, and
instructs the model to apply only the triaged verdicts. Bear notes
tagged rfd/<id>/apply are attached when found.

The rfd-reviewer persona is updated to handle continuation rounds: it
now knows to engage with the jp:// triage attachment, acknowledge
resolved concerns, and re-raise unresolved ones rather than redoing
critique already applied.

The `rfd-review`, and `rfd-triage` commands have been reworked to
support iterative review cycles without losing conversation context. A
new `rfd-apply` command is introduced to apply triage verdicts back to
the RFD file.

Two private helpers centralise repeated logic that was previously
copy-pasted across commands. `_resolve-conversation TITLE` looks up an
active conversation by title and prompts the user to continue,
archive-and-restart, or quit, emitting a tagged token the caller
dispatches on. `_bear-note TAG` resolves a Bear note by tag and prompts
when none is found, emitting FOUND/EDIT/CONTINUE/QUIT. Both `pr-review`
and `pr-triage` are updated to use `_resolve-conversation` in place of
their own inline lookup-and-prompt blocks.

`rfd-review` now titles its conversation `rfd-review:<id>`, supports
resuming that conversation across cycles, and — in continuation mode —
automatically attaches the latest user/assistant turn from the sibling
`rfd-triage:<id>` conversation so the reviewer can engage with the
triager's response from the prior round. Bear notes tagged
`rfd/<id>/review` are attached when found.

`rfd-triage` drops the positional `MODE` and `CONVO` arguments. It now
discovers the sibling `rfd-review:<id>` conversation automatically
(failing fast if none exists), titles its own conversation
`rfd-triage:<id>`, and supports continuation via
`_resolve-conversation`. Bear notes tagged `rfd/<id>/triage` are
attached when found.

`rfd-apply` is a new command that resumes the `rfd-triage:<id>`
conversation with the dev persona, re-attaches the current RFD file, and
instructs the model to apply only the triaged verdicts. Bear notes
tagged `rfd/<id>/apply` are attached when found.

The rfd-reviewer persona is updated to handle continuation rounds: it
now knows to engage with the `jp://` triage attachment, acknowledge
resolved concerns, and re-raise unresolved ones rather than redoing
critique already applied.

Signed-off-by: Jean Mertz <git@jeanmertz.com>
@JeanMertz JeanMertz merged commit 0d70798 into main May 11, 2026
14 checks passed
@JeanMertz JeanMertz deleted the prr194 branch May 11, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant