Conversation
Path validation (absolute path, component length, component count) was previously skipped during the format-arguments phase, meaning invalid paths could pass through undetected until actual execution. The checks are now hoisted above the `is_format_arguments` branch so they apply consistently in both phases. The "Created file" preview message was also corrected to "Creating file" to better reflect that the format phase is showing intent, not reporting a completed action. A test covering the absolute-path rejection during the format phase was added to guard against regressions. Signed-off-by: Jean Mertz <git@jeanmertz.com>
…ate_file` Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Path validation (absolute path, component length, component count) was
previously skipped during the format-arguments phase, meaning invalid
paths could pass through undetected until actual execution. The checks
are now hoisted above the
is_format_argumentsbranch so they applyconsistently in both phases.
The "Created file" preview message was also corrected to "Creating file"
to better reflect that the format phase is showing intent, not reporting
a completed action.
A test covering the absolute-path rejection during the format phase was
added to guard against regressions.