Conversation
When a config field is flattened (`#[serde(flatten)]`), its key segment should not be pushed onto the field path, since flattened fields don't occupy their own level in the config hierarchy. Previously, the field key was always pushed regardless of flattening, causing incorrect paths in error reporting. Additionally, nested list and map iteration now tracks the index or key at each level — lists enumerate their items so the numeric index can be appended to the path, and maps append the map key — giving precise field paths for errors inside nested collections. As an example, previously, if a tool config had an invalid `source` config, errors would incorrectly report paths such as `conversation.tools.tools.source`. Now they correctly print `conversation.tools.<tool-name>.source`. Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a config field is flattened (
#[serde(flatten)]), its key segment should not be pushed onto the field path, since flattened fields don't occupy their own level in the config hierarchy. Previously, the field key was always pushed regardless of flattening, causing incorrect paths in error reporting.Additionally, nested list and map iteration now tracks the index or key at each level — lists enumerate their items so the numeric index can be appended to the path, and maps append the map key — giving precise field paths for errors inside nested collections.
As an example, previously, if a tool config had an invalid
sourceconfig, errors would incorrectly report paths such asconversation.tools.tools.source. Now they correctly printconversation.tools.<tool-name>.source.