Conversation
Extract a generic `CommandConfig` / `CommandConfigOrString` type under `jp_config::types::command`, replacing the tool-scoped `ToolCommandConfig`. The new type lives at the config-types layer so it can be shared by tools, labels, and any other consumer that needs to model an external command. String shorthands now use shell-word semantics via `shlex` instead of `split_ascii_whitespace`. This means quoting is respected at config-parse time, so `command = "nvim -c 'set ft=md'"` correctly passes two arguments (`-c` and `set ft=md`) rather than three. Inputs with unbalanced quotes are rejected at parse time rather than producing garbage at spawn time. The same `shlex`-based splitting is applied to `EditorConfig::command` and `EditorConfig::path` when reading editor env-vars (`JP_EDITOR`, `VISUAL`, `EDITOR`). Previously only the first whitespace-separated token was used; now `JP_EDITOR="code --wait"` correctly invokes `code` with `--wait` as an argument. Env-var values with unbalanced quoting are skipped and the next variable in the list is tried instead. Signed-off-by: Jean Mertz <git@jeanmertz.com>
…parsing Signed-off-by: Jean Mertz <git@jeanmertz.com>
…parsing Signed-off-by: Jean Mertz <git@jeanmertz.com>
…parsing Signed-off-by: Jean Mertz <git@jeanmertz.com>
…parsing Signed-off-by: Jean Mertz <git@jeanmertz.com>
…parsing Signed-off-by: Jean Mertz <git@jeanmertz.com>
…parsing Signed-off-by: Jean Mertz <git@jeanmertz.com>
…parsing Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract a generic
CommandConfig/CommandConfigOrStringtype underjp_config::types::command, replacing the tool-scopedToolCommandConfig. The new type lives at the config-types layer so it can be shared by tools, labels, and any other consumer that needs to model an external command.String shorthands now use shell-word semantics via
shlexinstead ofsplit_ascii_whitespace. This means quoting is respected at config-parse time, socommand = "nvim -c 'set ft=md'"correctly passes two arguments (-candset ft=md) rather than three. Inputs with unbalanced quotes are rejected at parse time rather than producing garbage at spawn time.The same
shlex-based splitting is applied toEditorConfig::commandandEditorConfig::pathwhen reading editor env-vars (JP_EDITOR,VISUAL,EDITOR). Previously only the first whitespace-separated token was used; nowJP_EDITOR="code --wait"correctly invokescodewith--waitas an argument. Env-var values with unbalanced quoting are skipped and the next variable in the list is tried instead.