Conversation
The box table rendered by `jp conversation ls` could overflow the terminal when conversation titles were long, mangling the box-drawing borders and making the output hard to read. The command now reads the terminal width at startup (stored as `ctx.term.width`, `None` when stdout is piped) and uses it to decide how to handle the title column before rendering. It first probes the table at full width, then compares the rendered width against the terminal. If the table overflows, the title is truncated to the remaining budget; if even a header-width column would overflow, the title column is dropped entirely. Piped and JSON output are unaffected and always receive full titles. Unicode display widths are computed via `unicode-width`, and ANSI colour codes plus OSC 8 hyperlinks are stripped before measuring so that invisible bytes do not distort the fit calculation. Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The box table rendered by
jp conversation lscould overflow the terminal when conversation titles were long, mangling the box-drawing borders and making the output hard to read.The command now reads the terminal width at startup (stored as
ctx.term.width,Nonewhen stdout is piped) and uses it to decide how to handle the title column before rendering. It first probes the table at full width, then compares the rendered width against the terminal. If the table overflows, the title is truncated to the remaining budget; if even a header-width column would overflow, the title column is dropped entirely. Piped and JSON output are unaffected and always receive full titles.Unicode display widths are computed via
unicode-width, and ANSI colour codes plus OSC 8 hyperlinks are stripped before measuring so that invisible bytes do not distort the fit calculation.