Add post-apply reminder about install.conf secrets#178
Conversation
After a successful install, remind the user that install.conf contains secrets and can be safely deleted now that they are in /etc/kai/env. Don't auto-delete - the user may want to re-run apply or adjust config. Fixes #165
Review by KaiOverall: Clean PR. Two minor suggestions. suggestion — The test only asserts the reminder doesn't appear in dry run. There's no test asserting it does appear when suggestion — f"\nNote: {INSTALL_CONF} contains secrets (bot token, webhook secret)."Naming the specific secret types in terminal output is a minor information-disclosure concern — anyone with access to terminal history or logs now knows exactly what credentials to look for if they can get the file. The message is still useful without the parenthetical. Consider: f"\nNote: {INSTALL_CONF} contains secrets."No bugs, no logic errors, no injection or auth issues. The |
Summary
Add a reminder after successful
make installthatinstall.confcontains secrets and can be safely deleted now that they are in/etc/kai/env.The file is already 0600 and gitignored, so the risk is low. But keeping unnecessary copies of secrets is bad hygiene, and the user may not realize
install.confstill contains them. The reminder is informational only - no auto-deletion.Changes
install.confsecrets with deletion guidanceINSTALL_CONF.exists()guardTest plan
make checkcleansudo make installand verify the reminder appearsFixes #165