You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Good addition — the assert_not_called() check on the mock is particularly valuable here, confirming that auth rejection short-circuits before the MT5 layer is reached rather than just checking the status code. The OpenAPI schema assertion is also a nice low-cost regression guard.
Two items worth addressing:
Missing invalid-key test for symbols (inline comment on test_auth.py): the version endpoint covers all three auth cases (missing key, invalid key, valid key); the symbols additions only cover two. The invalid-key branch produces a distinct error shape that's worth locking down.
Note placement in docs/index.md (inline comment): the "Replace windows-host..." note sits after the uvicorn startup command rather than before the curl examples, which is slightly misleading.
The documentation switch from powershell/curl.exe to console/curl is a clear improvement for cross-platform readers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/v1/symbols401when auth is enabled and no API key is providedMT5_API_KEYis unsetVerification
./scripts/qa.shContext
/api/v1/symbols?group=*USD*returning a503whenMT5_API_KEYwas unset