Skip to content

Rename mt5api env vars to MT5API_#17

Merged
dceoy merged 2 commits intomainfrom
codex/rename-mt5api-env-vars
Mar 16, 2026
Merged

Rename mt5api env vars to MT5API_#17
dceoy merged 2 commits intomainfrom
codex/rename-mt5api-env-vars

Conversation

@dceoy
Copy link
Copy Markdown
Owner

@dceoy dceoy commented Mar 16, 2026

Summary

  • rename the app environment variable prefix from API_ to MT5API_
  • update configuration lookups, CLI/config tests, and router-prefix validation messaging
  • refresh README, docs, and quickstart examples to use the new variable names

Testing

  • /Users/dceoy/util/mt5api/.agents/skills/local-qa/scripts/qa.sh
  • uv run mkdocs build

@dceoy dceoy added documentation Improvements or additions to documentation enhancement New feature or request codex labels Mar 16, 2026
@dceoy dceoy self-assigned this Mar 16, 2026
@dceoy dceoy marked this pull request as ready for review March 16, 2026 13:38
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, well-executed rename. The code changes are consistent — all ENV_API_* constants, config lookups, tests, and documentation within the PR correctly use the new MT5API_ prefix. No stale references remain in any .py file or in the docs/specs touched by this PR.

Positive notes:

  • Good separation between ENV_MT5API_* (user-facing env var names) and DEFAULT_API_* (internal defaults) — no need to rename the latter.
  • Tests import constants symbolically rather than hardcoding strings, which made this rename safe and verifiable.
  • The error message update ("Invalid MT5API_ROUTER_PREFIX") and its corresponding test assertion are in sync.

One issue flagged below as inline comments.

🤖 Generated with Claude Code

Comment thread mt5api/constants.py
@dceoy dceoy merged commit 89edb6d into main Mar 16, 2026
5 checks passed
@dceoy dceoy deleted the codex/rename-mt5api-env-vars branch March 16, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant