Merged
Conversation
There was a problem hiding this comment.
Clean, well-executed rename. The code changes are consistent — all ENV_API_* constants, config lookups, tests, and documentation within the PR correctly use the new MT5API_ prefix. No stale references remain in any .py file or in the docs/specs touched by this PR.
Positive notes:
- Good separation between
ENV_MT5API_*(user-facing env var names) andDEFAULT_API_*(internal defaults) — no need to rename the latter. - Tests import constants symbolically rather than hardcoding strings, which made this rename safe and verifiable.
- The error message update (
"Invalid MT5API_ROUTER_PREFIX") and its corresponding test assertion are in sync.
One issue flagged below as inline comments.
🤖 Generated with Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
API_toMT5API_Testing
/Users/dceoy/util/mt5api/.agents/skills/local-qa/scripts/qa.shuv run mkdocs build