Add mt5cli skill documentation for MetaTrader 5 data export#7
Merged
Conversation
Document mt5cli CLI usage (global options, subcommands, parameter formats, and examples) so agents can invoke the exporter without re-reading the CLI source.
Mirror the conventional layout: keep the canonical SKILL.md under skills/mt5cli/ and expose it through a .agents/skills/mt5cli symlink.
There was a problem hiding this comment.
Review Summary
Clean, well-structured documentation PR. The SKILL.md content is highly accurate — all 13 subcommands, required/optional parameter classifications, default values, timeframe/tick-flag names, and file extension mappings were verified against mt5cli/cli.py and match the implementation exactly.
A few items worth addressing below (posted as inline comments).
No concerns from performance or test-coverage perspectives — this is a docs-only change with no runtime impact.
Add a guideline warning against passing --password on the command line (visible in ps/history/logs), and drop the credential-inline example that modeled the bad pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive skill documentation for the
mt5clicommand-line tool, which enables exporting MetaTrader 5 market and account data to multiple formats (CSV, JSON, Parquet, SQLite3).Changes
.agents/skills/mt5cli/SKILL.mdNotable Details
--log-level DEBUGfor connection issues)uv runwrapper for repository contexthttps://claude.ai/code/session_01AdNLzSgfQQC1AVSDeXqC5e