Fix MT5 initialization and sdist bug regressions#96
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a802109f17
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dceoy
commented
Jul 3, 2026
dceoy
left a comment
Owner
Author
There was a problem hiding this comment.
Reviewed the current head after the follow-up fix. No blocking issues found.
Checked:
Mt5Client.initialize()now forwards credentials/timeout withoutpath.Mt5DataClient.__enter__()now uses config-aware initialization and retry flow.- failed/exception login paths shut down the initialized MT5 session before raising/retrying.
version()now normalizesNoneresponses toMt5RuntimeError.- positional
skip_to_datetime/index_keysare now honored through signature binding. - hatchling sdist selection is aligned with the active build backend.
CI/CD is green on the latest commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mt5Client.initialize()is called without a terminal pathMt5DataClientcontext managers honorMt5Configandretry_count, and handleversion()Noneresults asMt5RuntimeErrorskip_to_datetime/index_keysdecorator arguments and move sdist file selection tohatchlingTesting
uv run pytestuv run ruff check .uv run pyright .uv buildtests,uv.lock,.github, and.agentsFixes #89
Fixes #90
Fixes #91
Fixes #92
Fixes #94