Skip to content

Fix MT5 initialization and sdist bug regressions#96

Merged
dceoy merged 3 commits into
mainfrom
bugfix/fix-bug-89-94
Jul 3, 2026
Merged

Fix MT5 initialization and sdist bug regressions#96
dceoy merged 3 commits into
mainfrom
bugfix/fix-bug-89-94

Conversation

@dceoy

@dceoy dceoy commented Jul 3, 2026

Copy link
Copy Markdown
Owner

Summary

  • preserve initialization credentials even when Mt5Client.initialize() is called without a terminal path
  • make Mt5DataClient context managers honor Mt5Config and retry_count, and handle version() None results as Mt5RuntimeError
  • honor positional skip_to_datetime / index_keys decorator arguments and move sdist file selection to hatchling

Testing

  • uv run pytest
  • uv run ruff check .
  • uv run pyright .
  • uv build
  • inspected the built sdist to confirm it excludes tests, uv.lock, .github, and .agents

Fixes #89
Fixes #90
Fixes #91
Fixes #92
Fixes #94

@dceoy dceoy self-assigned this Jul 3, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a802109f17

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread pdmt5/dataframe.py

@dceoy dceoy left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the current head after the follow-up fix. No blocking issues found.

Checked:

  • Mt5Client.initialize() now forwards credentials/timeout without path.
  • Mt5DataClient.__enter__() now uses config-aware initialization and retry flow.
  • failed/exception login paths shut down the initialized MT5 session before raising/retrying.
  • version() now normalizes None responses to Mt5RuntimeError.
  • positional skip_to_datetime / index_keys are now honored through signature binding.
  • hatchling sdist selection is aligned with the active build backend.

CI/CD is green on the latest commit.

@dceoy dceoy merged commit 208813e into main Jul 3, 2026
6 checks passed
@dceoy dceoy deleted the bugfix/fix-bug-89-94 branch July 3, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment