Skip to content
This repository was archived by the owner on Apr 4, 2026. It is now read-only.

Add option to split compose manager into separate Tab in Unraid#29

Merged
dcflachs merged 15 commits intodcflachs:mainfrom
ich777:ich777-patch-1
Sep 7, 2024
Merged

Add option to split compose manager into separate Tab in Unraid#29
dcflachs merged 15 commits intodcflachs:mainfrom
ich777:ich777-patch-1

Conversation

@ich777
Copy link
Copy Markdown
Contributor

@ich777 ich777 commented Sep 2, 2024

  • Add possibility for users to split out the Compose Manager into it's own separate Tab in the Unraid Header menu
  • Redid how Docker service is running or not is detected
  • Modify plugin file to inject COMPOSE_TAB="false" if not found in config file
  • Modify default.cfg to include COMPOSE_TAB="false"

@dcflachs
Copy link
Copy Markdown
Owner

dcflachs commented Sep 5, 2024

One minor note, in the Azure/Grey theme the compose manager icon and the lxc plugin icon are the same.
I have been using "cubes" for the compose manager icon for a couple of years now on the settings page and the as the main plugin icon. I guess i didnt consider any conflicts when i recommended the same icon for you last year https://forums.unraid.net/topic/123935-plugin-lxc-plugin/?do=findComment&comment=1262702
image
image

@ich777
Copy link
Copy Markdown
Contributor Author

ich777 commented Sep 5, 2024

One minor note, in the Azure/Grey theme the compose manager icon and the lxc plugin icon are the same.

Yes I know about that and that's simply because LXC doesn't have a black and white icon or a Icon that I could easily add so that it matches the overall style, however that should not be your problem and I might change that in the future.

However the compose Tab/Section is set to always be right after the Docker Tab/Section and after that LXC.

The cubes which you are using are perfectly fine for Compose, my Icon needs to be changed.

EDIT: I'm not quiet decided what to use:
grafik
grafik
grafik
grafik

For the default theme it's pretty obvious, however I can't use this for the Grey and Azure theme because these themes rely entirely on icons from Font Awesome:
grafik

@ich777
Copy link
Copy Markdown
Contributor Author

ich777 commented Sep 5, 2024

BTW I think you should change this line to:
Menu="OtherSettings"
since your plugin is a System plugin and not a User Utility.

This is the new LXC logo for Azure and Grey theme:
grafik

- fix for Autostart switch not showing up
@dcflachs
Copy link
Copy Markdown
Owner

dcflachs commented Sep 5, 2024

BTW I think you should change this line to: Menu="OtherSettings" since your plugin is a System plugin and not a User Utility.

Do you know if there is official guidance for this? I was under the impression that "User Utility" was the proper place for all plugins/third party extensions.

This is the new LXC logo for Azure and Grey theme

I like it.

@ich777
Copy link
Copy Markdown
Contributor Author

ich777 commented Sep 5, 2024

Do you know if there is official guidance for this? I was under the impression that "User Utility" was the proper place for all plugins/third party extensions.

I see compose not really as a "User Utility" it's more a System Utility and that's why I'm under the impression it has to be right at the section where Docker, LXC and VMs are.
The NUT plugin settings are also there for example:
grafik

User utilities are GPU Statistics, Intel-GPU-TOP or other tools.

I like it.

Thanks.

I also pushed a small fix because the Autostart button was not showing up properly and you had a dot in the Readme from the plugin <- don't know if that was by accident.

@ich777
Copy link
Copy Markdown
Contributor Author

ich777 commented Sep 5, 2024

@dcflachs what do you think, ready to merge?

@dcflachs
Copy link
Copy Markdown
Owner

dcflachs commented Sep 6, 2024

There is a bit of a graphical anomaly in the Azure/Grey theme when using the new tab option. Something about the line spacing changes so that it looks like this
image
instead of this
image
It doesnt appear in the Black/White themes for some reason. I wasnt able to figure out the reason this evening.

Comment thread source/compose.manager/Compose.page Outdated
Menu="Tasks:61"
Type="xmenu"
Title="Docker Compose"
Tabs="true"
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think we need

Tabs="true"

network they are attached to no longer exists.
</blockquote>

_(Compose Tab)_:
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think i would like to change this setting name to something like

_(Show Compose in Header Menu)_

</blockquote>

_(Compose Tab)_:
: <select name="COMPOSE_TAB">
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather have the configuration variable named something like

SHOW_COMPOSE_IN_HEADER_MENU

</select>

<blockquote class="inline_help">
This will split Compose Manager section into it's separate tab in the Unraid Header menu.
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to something like

This will move the Compose Manager page to a separate tab in the Unraid Header menu. 

@ich777
Copy link
Copy Markdown
Contributor Author

ich777 commented Sep 6, 2024

@dcflachs all changes/issues are now implemented/resolved.
BTW, you should be able to edit anything you want in that PR because I allow edit by maintainers if you find anything else.

What I didn't change is the placement of the Settings menu, I would strongly recommend that you change that so that it shows up where it belongs, however that's up to you.

@dcflachs dcflachs merged commit b0d3549 into dcflachs:main Sep 7, 2024
Belphemur pushed a commit to Belphemur/compose_plugin that referenced this pull request Oct 16, 2024
…achs#29)

* Add files via upload

* Update compose.manager.plg

* remove Unraid version check

* Modified how Docker service is running or not is detected

* Removed Unraid version check

* Show Autostart switch

- fix for Autostart switch not showing up

* Replace . with ` `

* Update Compose.page

* Update compose.manager.settings.page

* Update default.cfg

* Update compose.manager.page

* Update Compose.page

* Update compose.manager.settings.page

* Update Compose.page

* Update compose.manager.plg with corrected variable name

---------

Co-authored-by: dcflachs <dcflachs@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants