feat(web): previewImage 支持点击 esc 关闭预览 (question/209551) #5480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size report
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for closing the image preview when the user presses the Escape key.
- Imports and activates the
useKeyboardhook. - Watches for the Escape key (
Esc) to callonClick()and emit the close event.
Comments suppressed due to low confidence (2)
packages/uni-h5/src/service/api/media/previewImage/ImagePreview.tsx:48
- [nitpick] The variable name
keyis very generic and may conflict or be confusing. Consider renaming it to something more descriptive likepressedKeyoractiveKey.
const { key } = useKeyboard()
packages/uni-h5/src/service/api/media/previewImage/ImagePreview.tsx:55
- [nitpick] There's no test covering the new Escape-key-to-close behavior. Consider adding a unit or integration test to verify that pressing Escape triggers the close event.
watch(
| watch( | ||
| () => key.value, | ||
| (value) => { | ||
| if (value === 'esc') { |
There was a problem hiding this comment.
KeyboardEvent.key for the Escape key is typically "Escape", not "esc". Update the comparison to value === 'Escape' to ensure the handler triggers correctly.
Suggested change
| if (value === 'esc') { | |
| if (value === 'Escape') { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
社区帖子
https://ask.dcloud.net.cn/question/209551
效果
esc.mp4