fix: Missing variable name #106
Conversation
There was a problem hiding this comment.
This is no longer a valid code, so I applied the allowed value.
|
Would it be possible for you to separate the style changes from the substance changes into different commits for easier review? |
src/api.js
Outdated
| const request = getRequestOptions(options.request) | ||
| return this._httpGetApplicationJson(url, {}, false, withCredentials); | ||
|
|
||
| const request = getRequestOptions(options.request); |
There was a problem hiding this comment.
The series retrieve was passing false in instead of the request object that got created on the previous line.
Done. |
Thanks - 👍 Let me know when you are finished tweaking and I'll review. |
|
@pieper - I'm done tweaking if you could review. |
| extends: ['airbnb-base', 'prettier'], | ||
| rules: { | ||
| 'import/extensions': "always", // Better for native ES Module usage | ||
| 'import/extensions': 2, // Better for native ES Module usage |
There was a problem hiding this comment.
Is there a reason why the symbol is changed to a magic number? What does 2 mean?
|
Also it looks like the tests aren't running because the ubuntu version is old. Can we just change it to a newer version? |
|
@pieper - I'm not sure how to get it building, something in the import isn't quite right. Is it ok if I just use bun to build it instead? That build is quite fast, and is what i normally use to build it locally. Reduces the dependencies on things like rollup. |
|
@wayfarer3130 yes, if you know a way to get it working that's fine with me. I'm not up to date on those tools. |
|
🎉 This PR is included in version 0.11.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Any call to retrieveSeriesMetadata was failing because of an undeclared variable.
Also, re-linted api.js and fixed an eslint rule that is no longer valid.