Build: Upgrade probot, jest, and nock#275
Open
tykeal wants to merge 1 commit into
Open
Conversation
|
@tykeal is attempting to deploy a commit to the DCO App Team on Vercel. A member of the Team first needs to authorize it. |
tykeal
force-pushed
the
chore/upgrade-probot-14
branch
from
08e4407 to
2245918
Compare
tykeal
force-pushed
the
chore/upgrade-probot-14
branch
from
2245918 to
1041a13
Compare
tykeal
force-pushed
the
chore/upgrade-probot-14
branch
from
1041a13 to
76a1b28
Compare
tykeal
changed the title
tykeal
force-pushed
the
chore/upgrade-probot-14
branch
from
76a1b28 to
a81c833
Compare
Upgrade probot from ^12.1.1 to ^14.3.2. Migrate seven REST endpoint calls to context.octokit.rest.* and lazily wrap async createNodeMiddleware initialization for the webhook handler. Upgrade nock from ^13 to ^14 because probot 14 uses native fetch and undici paths that nock 13 cannot intercept, closing the dedicated nock upgrade issue. Upgrade Jest from ^27 to ^30. Jest 27 fails on Node 24 with ReferenceError: Request is not defined from @mswjs/interceptors via nock 14, and Jest 28 fails with Cannot find module #crypto from probot 14 dependencies. Fix tests to use ProbotOctokit instead of the undefined ProbotOctokitCore export, make beforeEach async, and await probot.load. Add webhook entry tests for the async serverless middleware wrapper. Run Jest through node so the VM modules flag is shell-agnostic. Keep package-lock.json skipped in codespell for regenerated lockfile integrity-hash false positives. npm audit --omit=dev moved from 17 total, 0 high, 0 critical to 0 total, 0 high, 0 critical. Full npm audit moved from 26 total, 0 high, 0 critical to 0 total, 0 high, 0 critical. Closes dcoapp#260 Closes dcoapp#261 Closes dcoapp#262 Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
tykeal
force-pushed
the
chore/upgrade-probot-14
branch
from
a81c833 to
7811d0b
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
context.octokit.rest.*.createNodeMiddlewareinitialization with rejection handling.ReferenceError: Request is not definedfrom nock 14's@mswjs/interceptors.Cannot find module '#crypto'.node --experimental-vm-modules ...so the test script is shell-agnostic.ProbotOctokitand awaitedprobot.load.Validation
npm test: 3 suites, 220 tests, 15 snapshots passed; 100% statements/branches/functions/lines coverage for all listed files, includingapi/github/webhooks/index.js; prettier clean.npm audit --omit=dev: 17 total / 0 high / 0 critical before; 0 total / 0 high / 0 critical after.npm audit: 26 total / 0 high / 0 critical before; 0 total / 0 high / 0 critical after.The Vercel preview deploy check is org-gated for fork PRs and may require maintainer authorization.
Closes #260
Closes #261
Closes #262