Removed unreferenced variable "rnd"#9
Closed
jordaaash wants to merge 1 commit intodcodeIO:masterfrom
jordaaash:patch-1
Closed
Removed unreferenced variable "rnd"#9jordaaash wants to merge 1 commit intodcodeIO:masterfrom jordaaash:patch-1
jordaaash wants to merge 1 commit intodcodeIO:masterfrom
jordaaash:patch-1
Conversation
The variable `rnd` was declared and set but then is not used on line 755. Instead, `rounds` is used, which causes the function to error if a `rounds` argument is not provided and instead the function is called with only a callback argument. This causes an asynchronous exception, `Error: Illegal argument types: function` to be thrown on line 756. The code now mirrors that of the `genSaltSync` method.
Author
|
Sorry about the whitespace changes, my editor did this automatically. I also ran tests and performed an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The variable
rndwas declared and set but then is not used on line 755. Instead,roundsis used, which causes the function to error if aroundsargument is not provided and instead the function is called with only a callback argument. This causes an asynchronous exception,Error: Illegal argument types: functionto be thrown on line 756. The code now mirrors that of thegenSaltSyncmethod.