feat(sync): Close remote issues when deleting synced tasks#100
Merged
Conversation
When running `dex remove` on a task that has been synced to GitHub, the corresponding GitHub issue is now automatically closed. This maintains consistency with how create/update operations sync to remote integrations. - Add optional `closeRemote` method to `RegisterableSyncService` interface - Implement `closeRemote` in `GitHubSyncService` to close issues - Update `TaskService.delete` to close remote issues before deleting - Close operations run in parallel for efficiency - Errors closing remote issues are logged but don't block local delete Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
dex removeon a task synced to GitHub, the correspondingGitHub issue is now automatically closed. This maintains consistency with
how create/update operations sync to remote integrations.
Previously, deleting a synced task would only remove it locally, leaving
the GitHub issue orphaned and open. Now the local storage remains the
source of truth and deletions propagate to the remote.
Changes:
closeRemotemethod toRegisterableSyncServiceinterfacecloseRemoteinGitHubSyncServiceTaskService.deleteto close remote issues before local deletion