-
Notifications
You must be signed in to change notification settings - Fork 16
Endorsement chain #564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Endorsement chain #564
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new "Endorsement Chain" API for electronic Bills of Lading (eBL), providing functionality to track the chain of endorsements and actions performed on transport documents throughout their lifecycle.
- Adds comprehensive OpenAPI specification for the eBL Endorsement Chain API
- Introduces GET endpoint for retrieving endorsement chains by transport document reference
- Includes detailed schema definitions for endorsement chain links, parties, and error responses
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| ebl/v3/endorsement/README.md | Introduces documentation for the new Endorsement Chain API with links to specifications and release notes |
| ebl/v3/endorsement/EBL_END_3.0.2.yaml | Complete OpenAPI specification defining the endorsement chain endpoint, request/response schemas, and comprehensive examples |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||||||||||
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| The value **MUST** be one of: | ||
| - `WAVE` (Wave) | ||
| - `CARX` (CargoX) | ||
| - `ESSD` (EssDOCS - This value has been **deprecated**. Please use `IDT`) |
Copilot
AI
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation indicates ESSD is deprecated in favor of IDT, but both values are still listed as valid options. Consider adding a deprecation notice or removal timeline to clarify the migration path.
| - `ESSD` (EssDOCS - This value has been **deprecated**. Please use `IDT`) | |
| - `ESSD` (EssDOCS - **Deprecated**: This value has been deprecated in favor of `IDT`. Support for `ESSD` will be removed in a future version. Please migrate to `IDT` as soon as possible.) |
| The value **MUST** be one of: | ||
| - `WAVE` (Wave) | ||
| - `CARX` (CargoX) | ||
| - `ESSD` (EssDOCS - This value has been **deprecated**. Please use `IDT`) |
Copilot
AI
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the ActorParty schema, the RecipientParty schema also lists ESSD as deprecated but still valid. Consider consistent handling of deprecated values across all party schemas.
|
|
||
| - `WAVE` (Wave) | ||
| - `CARX` (CargoX) | ||
| - `ESSD` (EssDOCS - This value has been **deprecated**. Please use `IDT`) |
Copilot
AI
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The IdentifyingCode schema also includes the deprecated ESSD value. For consistency, all schemas referencing eBL platforms should handle the ESSD deprecation uniformly.
PR Type
Enhancement
Description
Add DCSA eBL Endorsement Chain API v3.0.2
Implement GET endpoint for endorsement chain retrieval
Include comprehensive schema definitions and examples
Add documentation and README for API usage
Diagram Walkthrough
flowchart LR API["eBL Endorsement Chain API"] --> GET["/endorsement-chains/{ref}"] GET --> Schema["EndorsementChainX Schema"] Schema --> Examples["Surrender Examples"] API --> README["Documentation"]File Walkthrough
EBL_END_3.0.2.yaml
Add complete eBL Endorsement Chain API specificationebl/v3/endorsement/EBL_END_3.0.2.yaml
document reference
and error responses
without on-behalf parties
README.md
Add API documentation and READMEebl/v3/endorsement/README.md