Skip to content

Fixed bug in layers.set_params() #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddbourgin merged 2 commits into from
Mar 5, 2021
Merged

Fixed bug in layers.set_params() #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51d82a7
Fixed bug in layers.set_params()
RaulMurillo Mar 4, 2021
3db6423
Fixed bug in NN initializers
RaulMurillo Mar 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions numpy_ml/neural_nets/initializers/initializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,13 +122,14 @@ def init_from_dict(self):
raise ValueError("Must have `hyperparameters` key: {}".format(S))

if sc and sc["id"] == "ConstantScheduler":
scheduler = ConstantScheduler().set_params(sc)
scheduler = ConstantScheduler()
elif sc and sc["id"] == "ExponentialScheduler":
scheduler = ExponentialScheduler().set_params(sc)
scheduler = ExponentialScheduler()
elif sc and sc["id"] == "NoamScheduler":
scheduler = NoamScheduler().set_params(sc)
scheduler = NoamScheduler()
elif sc:
raise NotImplementedError("{}".format(sc["id"]))
scheduler.set_params(sc)
return scheduler


Expand Down Expand Up @@ -182,15 +183,16 @@ def init_from_dict(self):
raise ValueError("Must have `hyperparemeters` key: {}".format(O))

if op and op["id"] == "SGD":
optimizer = SGD().set_params(op, cc)
optimizer = SGD()
elif op and op["id"] == "RMSProp":
optimizer = RMSProp().set_params(op, cc)
optimizer = RMSProp()
elif op and op["id"] == "AdaGrad":
optimizer = AdaGrad().set_params(op, cc)
optimizer = AdaGrad()
elif op and op["id"] == "Adam":
optimizer = Adam().set_params(op, cc)
optimizer = Adam()
elif op:
raise NotImplementedError("{}".format(op["id"]))
optimizer.set_params(op, cc)
return optimizer


Expand Down
8 changes: 4 additions & 4 deletions numpy_ml/neural_nets/layers/layers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,12 +119,12 @@ def set_params(self, summary_dict):
if k in self.hyperparameters:
if k == "act_fn":
layer.act_fn = ActivationInitializer(v)()
if k == "optimizer":
elif k == "optimizer":
layer.optimizer = OptimizerInitializer(sd[k])()
if k not in ["wrappers", "optimizer"]:
setattr(layer, k, v)
if k == "wrappers":
elif k == "wrappers":
layer = init_wrappers(layer, sd[k])
elif k not in ["wrappers", "optimizer"]:
setattr(layer, k, v)
return layer

def summary(self):
Expand Down