-
Notifications
You must be signed in to change notification settings - Fork 384
ddclient makes invalid HTTP requests #332
Copy link
Copy link
Closed
Description
I noticed a problem recently where my updates were being refused despite valid credentials with "400 Bad Request". On investigation, this is because ddclient is making invalid requests: according to the HTTP 1.0 spec "A valid Content-Length is required on all HTTP/1.0 POST requests."
There are two obvious solutions:
- Make ddclient speak HTTP 1.1. This simply requires changing the version number.
- Add a
Content-Length: 0header in the case when there is no data being sent.
I've tried both solutions, and both work fine; the first is simpler, but perhaps there are still servers out there that don't speak HTTP 1.1?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels