Change feedback buttons and add nav menu#43
Merged
Conversation
dynamictulip
force-pushed
the
change-feedback-buttons
branch
from
80bf3c8 to
c63b726
Compare
dynamictulip
changed the title
There was a problem hiding this comment.
Pull request overview
This PR updates the Blazor client UI/state to distinguish event feedback vs session feedback, adds quick access to session feedback from the schedule, and replaces the header feedback button with a navigation drawer containing key links.
Changes:
- Track whether a session already has feedback (
HasFeedback) and load that info from local storage into the Home schedule model. - Add a “Give session feedback” action on each session card that opens the session feedback dialog.
- Replace the header feedback button with a hamburger menu + drawer nav (Home, feedback, venue map).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| PocketDDD.BlazorClient/Features/Home/Store/HomeState.cs | Adds HasFeedback to the home schedule session model. |
| PocketDDD.BlazorClient/Features/Home/Store/HomeReducer.cs | Passes session feedback IDs into the event-to-home mapper. |
| PocketDDD.BlazorClient/Features/Home/Store/HomeEffects.cs | Reloads home data when session feedback storage changes; loads session feedback IDs. |
| PocketDDD.BlazorClient/Features/Home/Store/HomeActions.cs | Extends SetEventMetaDataAction and adds GiveSessionFeedbackAction. |
| PocketDDD.BlazorClient/Features/Home/Store/EventDataMapper.cs | Maps HasFeedback into sessions based on stored feedback IDs. |
| PocketDDD.BlazorClient/Features/Home/Components/Home.razor | Subscribes to GiveSessionFeedbackAction and opens the session feedback dialog. |
| PocketDDD.BlazorClient/Features/Home/Components/EventData.razor | Adds a feedback toggle/icon action in the session button group. |
| PocketDDD.BlazorClient/Features/HeaderBar/Components/HeaderBar.razor | Replaces feedback button with a drawer nav menu and links. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
18
to
21
| <MudText Typo="Typo.h5">@State.Value.Title</MudText> | ||
| <MudSpacer /> | ||
|
|
||
| @if (State.Value.ShowFeedbackButton) | ||
| { | ||
| <MudButton | ||
| EndIcon="@Icons.Material.Filled.TagFaces" | ||
| Size="Size.Small" | ||
| OnClick="HandleShowEventFeedback" | ||
| Color="Color.Inherit" | ||
| Variant="Variant.Outlined"> | ||
| Feedback | ||
| </MudButton> | ||
| } | ||
|
|
||
| <MudIconButton Icon="@Icons.Material.Filled.Menu" Color="Color.Inherit" Edge="Edge.Start" OnClick="@OpenDrawer"/> | ||
| </MudAppBar> |
Comment on lines
30
to
34
| Title = s.Title, | ||
| SpeakerName = s.Speaker, | ||
| IsBookmarked = sessionBookmarks.Contains(s.Id) | ||
| IsBookmarked = sessionBookmarks.Contains(s.Id), | ||
| HasFeedback = sessionFeedbacks.Contains(s.Id) | ||
| }) |
dynamictulip
force-pushed
the
change-feedback-buttons
branch
from
c63b726 to
73c0a96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.