Add special case in discoverAVC to recognize Sony DVMC-DA1 as a video source#16
Merged
ddennedy merged 1 commit intoddennedy:masterfrom Nov 30, 2023
aaeegg:master
Merged
Add special case in discoverAVC to recognize Sony DVMC-DA1 as a video source#16ddennedy merged 1 commit intoddennedy:masterfrom aaeegg:master
ddennedy merged 1 commit intoddennedy:masterfrom
aaeegg:master
Conversation
ddennedy
requested changes
Nov 29, 2023
ddennedy
approved these changes
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Sony DVMC-DA1 is a media converter without a tape transport. discoverAVC expects video sources to identify as a VCR in response to a SUBUNIT INFO Function Control Protocol command. But the DVMC-DA1 doesn't implement the AV/C command set, so it doesn't respond to the SUBUNIT INFO request at all. As a result, dvgrab doesn't know the device is a video source, so it won't try to use it unless you explicitly point dvgrab at it by GUID.
discoverAVC already has one special case to recognize Motorola DCT set-top boxes. This change adds another special case to also recognize the DVMC-DA1. dvgrab will then use the DVMC-DA1 without requiring a --guid option.
Since discoverAVC will potentially discover a non-AV/C device, it also changes the status text from "Found AV/C device" to "Found video device".