Skip to content

fix: Don't overwrite files in timecode/timestamp/timsys mode#17

Merged
ddennedy merged 1 commit intoddennedy:masterfrom
mfep:fix-file-overwrite
Mar 6, 2025
Merged

fix: Don't overwrite files in timecode/timestamp/timsys mode#17
ddennedy merged 1 commit intoddennedy:masterfrom
mfep:fix-file-overwrite

Conversation

@mfep
Copy link
Copy Markdown
Contributor

@mfep mfep commented Nov 1, 2024

  • Sometimes subsequently recorded clips are written to the same path, erasing the previously written file.
    • This happens, e.g. when the dvgrab operates in --timestamp mode, and some recordings on the camera don't have timestamp information.
  • This patch addresses this problem by checking if the output file exists, and if so, the filename is postfixed with a numeric counter.
    • This is similar to the default filename composition logic.

@Soapsuds
Copy link
Copy Markdown

Soapsuds commented Mar 6, 2025

I also ran into the problem with files getting overwritten due to timestamp information being missing on some of my clips. This patch resolves the issue and still allows me to use timestamp mode. Thanks!

@ddennedy ddennedy merged commit 8e1f93d into ddennedy:master Mar 6, 2025
@mfep mfep deleted the fix-file-overwrite branch March 9, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants