Skip to content

Fix #21 PAL capture broken#23

Merged
ddennedy merged 4 commits intomasterfrom
fix-21-pal-dv
Mar 23, 2026
Merged

Fix #21 PAL capture broken#23
ddennedy merged 4 commits intomasterfrom
fix-21-pal-dv

Conversation

@ddennedy
Copy link
Copy Markdown
Owner

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses PAL DV capture failures by making DV frame-size detection robust (based on the DSF bit once available) and aligning downstream writers to use the “expected” DV size, while also updating project metadata (version + links).

Changes:

  • Add DV frame size detection via DSF bit and use it for “expected size”/completeness checks.
  • Update IEEE1394 DV capture bounds checking to avoid premature drops when PAL/NTSC is not yet known.
  • Bump release version and refresh project links/docs (README, man page, spec, help, NEWS).

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
ieee1394io.cc Uses DSF-based sizing during DV packet accumulation to prevent frame buffer overflow and PAL mis-sizing.
dvframe.h Introduces DVFrame::FrameSize() and GetExpectedSize() API; cleans up VideoInfo declaration.
dvframe.cc Implements DSF-to-size mapping, switches completeness logic to expected size, updates PAL detection logic.
filehandler.cc Writes QuickTime DV frames using the expected DV frame size.
configure.ac Bumps project version to 3.5.2.
NEWS Adds 3.5.2 release notes including PAL capture fix.
README Updates website/support links to GitHub.
dvgrab.cc Updates help output link to GitHub.
dvgrab.1 Fixes author email formatting and updates support link to GitHub.
dvgrab.spec Updates URL/copyright year.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ieee1394io.cc
Comment thread dvgrab.spec Outdated
@ddennedy ddennedy merged commit 34637fe into master Mar 23, 2026
@ddennedy ddennedy deleted the fix-21-pal-dv branch March 23, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants