Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses PAL DV capture failures by making DV frame-size detection robust (based on the DSF bit once available) and aligning downstream writers to use the “expected” DV size, while also updating project metadata (version + links).
Changes:
- Add DV frame size detection via DSF bit and use it for “expected size”/completeness checks.
- Update IEEE1394 DV capture bounds checking to avoid premature drops when PAL/NTSC is not yet known.
- Bump release version and refresh project links/docs (README, man page, spec, help, NEWS).
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
ieee1394io.cc |
Uses DSF-based sizing during DV packet accumulation to prevent frame buffer overflow and PAL mis-sizing. |
dvframe.h |
Introduces DVFrame::FrameSize() and GetExpectedSize() API; cleans up VideoInfo declaration. |
dvframe.cc |
Implements DSF-to-size mapping, switches completeness logic to expected size, updates PAL detection logic. |
filehandler.cc |
Writes QuickTime DV frames using the expected DV frame size. |
configure.ac |
Bumps project version to 3.5.2. |
NEWS |
Adds 3.5.2 release notes including PAL capture fix. |
README |
Updates website/support links to GitHub. |
dvgrab.cc |
Updates help output link to GitHub. |
dvgrab.1 |
Fixes author email formatting and updates support link to GitHub. |
dvgrab.spec |
Updates URL/copyright year. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.