feat(docs): guided start pages and landing UX for Drupal workspaces#167
Merged
Conversation
9 tasks
|
rfay
force-pushed
the
fix/156-landing-ux
branch
3 times, most recently
from
8c8754d to
3c6befe
Compare
Add pick-card controls, dark tokens, and logo assets; document patterns on /components.html.
Replace inline CSS on index, access-denied, and the default Jekyll layout with coder-ddev-start.css.
Use pick-card fields for version, profile, and site visibility; launch workspaces via mode=auto with prefilled params.
Point users at the issue picker and Drupal core start flows instead of a raw Open in Coder link.
Add a three-column hero layout, callout variants, and move sign-in guidance below the primary entry tiles.
Style footnote links with target flash, move access details to a second footnote, and fix notes section markup.
Fall back to issue NID when branch-based names exceed the limit and show inline field errors before launch.
Use announce callouts for ddev-drupal-dev and ddev-drupal-contrib documentation.
Point the Drupal Core tile at /drupal-core and remove a stray closing anchor tag.
Resolve module vs theme from the Drupal.org project node API so drupal-contrib launch URLs symlink themes into web/themes instead of web/modules.
…verflow - buildContribIssueUrl was passing currentNid as param.issue_fork instead of currentIssueFork (the fork name string like token-3568144); every contrib issue workspace launch was sending the wrong value - openManualWorkspace was passing nidFromFork instead of the full fork name - fetchDrupalOrgProjectType now returns null on failure instead of silently returning 'module'; loadIssue and loadPlainProject warn the user, and openManualWorkspace shows a visible status message before launching - suggestedIssueForkWorkspaceName now bounds-checks the NID fallback path and truncates to MAX_WORKSPACE_NAME_LENGTH to prevent server-side rejection - CORE_DISABLE_PARAMS moved to coder-workspace-name.js and imported by both drupal-core.html and drupal-issue.html, eliminating the duplicate Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…olumn grid The Drupal Issue picker covers the same use cases, making the Drupal Core tile redundant. Also removes the orphaned "Drupal core template includes" section and updates the "How it works" step to drop the drupal-core link. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jekyll-build-pages runs as root in Docker so sed -i cannot create temp files. chmod -R a+w before the find/sed fixes it. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jekyll-build-pages creates files owned by root; chmod and sed -i both fail. Copying to a new directory transfers ownership to the runner, making in-place sed edits work. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Absolute /drupal-issue breaks on GitHub Pages PR previews where the base path is not the root. Relative drupal-issue works in both production and preview environments. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
/favicon.svg and href="/" break on GitHub Pages PR previews where the base path is not the server root. Use favicon.svg and href="." so all links resolve correctly in both production and preview. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The cp and find commands were attached to the if: key as malformed YAML, so _site_preview was never created and the deploy step had no source to push. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
Author
|
I think this is doing what it should be doing now, thanks for this @jameswilson ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #156
Summary
Users landing on
start.coder.ddev.comwere often sent straight to the rawdrupal-coreCoder template in manual mode, where version/branch mismatches and opaque parameter choices caused confusion. This PR steers people through guided entry points on the start site, consolidates shared styling, and prefills workspace creation viamode=autoso the right template parameters are locked in before Coder opens.Landing page (
docs/index.html)/drupal-corefrom/drupal-issue.</a>)New guided start pages
/drupal-core(docs/drupal-core.html)coder/drupal-corewithmode=autoanddisable_paramsso version, profile, and visibility are prefilled and not accidentally changed in Coder/drupal-issue(docs/drupal-issue.html)drupal-corevsdrupal-contribtemplate automatically<select>dropdowns for version, profile, and site visibility (matches drupal-core)mode=auto+disable_paramson all three forms (result, plain, manual)param.project_type(modulevstheme) from the Drupal.org project node API (project_theme/project_module) so contrib themes symlink intoweb/themescorrectlyShared infrastructure
docs/coder-ddev-start.css.cds-namespace<style>blocks previously duplicated across pagesdocs/coder-workspace-name.js{version}-{profile}-{branch}would exceed the limitdocs/components.htmlLayout consolidation
docs/_layouts/default.html,docs/access-denied.html— drop inline CSS in favor of shared stylesheetdocs/logo-coder-on-dark.svg,docs/logo-ddev-on-dark.svgDocumentation updates
docs/user/quickstart.md/drupal-issueand/drupal-coreREADME.mdTemplate tweak (requires separate template push)
drupal-core/template.tfDemo Umami,Minimal,Standard)Test plan
start.coder.ddev.com/— two tiles render; Drupal tile goes to/drupal-issue; footnotes link and scroll correctly/drupal-issue— core issue (e.g. drupal.org core issue NID): loads branches, launchesdrupal-coretemplate/drupal-issue— contrib module issue: launchesdrupal-contribwithparam.project_type=module/drupal-issue— contrib theme (e.g.oliveroor theme issue): launches withparam.project_type=theme/drupal-issue— plain contrib machine name: plain-dev form, correct project type in URL/drupal-issue– links to/drupal-corein an info box near the top of the page/drupal-core— pick version/profile/visibility, launch URL containsmode=autoand expectedparam.*valuesterraform fmt/ validate ondrupal-coreif template push is included in this release🤖 Generated with Claude Code