-
-
Notifications
You must be signed in to change notification settings - Fork 21
Preserve TESTDIR when using Github Actions #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
stasadev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thought, we don't even need this DDEV_PRESERVE_TESTDIR, if we can look at GITHUB_ENV, right?
Please update the OP using the template. Giving link to external website is not useful.
Co-authored-by: Stanislav Zhuk <stasadev@gmail.com>
Co-authored-by: Stanislav Zhuk <stasadev@gmail.com>
Co-authored-by: Stanislav Zhuk <stasadev@gmail.com>
Co-authored-by: Stanislav Zhuk <stasadev@gmail.com>
stasadev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
julienloizelet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for me ! Thank you
|
Working example is in: |
|
Additional fix to upload all test results: |
The Issue
Allow bats runners to avoid deletion of the testdir. Helpful when uploading artifacts as per
How This PR Solves The Issue
Detect GITHUB_ENV env variable and avoid deleting the test directory. This is set to true for runs in GitHub Actions. Locally you can set it as well for same behavior.
Manual Testing Instructions
Working example is in: