Skip to content

feat: use official Adminer, fixes #31#33

Merged
stasadev merged 2 commits into
mainfrom
20250227_stasadev_adminer_official
Feb 28, 2025
Merged

feat: use official Adminer, fixes #31#33
stasadev merged 2 commits into
mainfrom
20250227_stasadev_adminer_official

Conversation

@stasadev
Copy link
Copy Markdown
Member

@stasadev stasadev commented Feb 27, 2025

The Issue

How This PR Solves The Issue

Manual Testing Instructions

# design: https://www.adminer.org/en/#extras
ddev dotenv set .ddev/.env.adminer --adminer-design=dracula
ddev add-on get https://github.com/ddev/ddev-adminer/tarball/20250227_stasadev_adminer_official
ddev restart

Automated Testing Overview

Release/Deployment Notes

Copy link
Copy Markdown
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great and works great, thanks! Just suggesting to make the config override stuff less likely to be seen and touched.

Comment thread README.md Outdated
Copy link
Copy Markdown
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that should keep them out of trouble.

Copy link
Copy Markdown
Contributor

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@stasadev stasadev merged commit 8dc433f into main Feb 28, 2025
@stasadev stasadev deleted the 20250227_stasadev_adminer_official branch February 28, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants