Head tests failing: `ERROR: "/cron.conf" not found` during build

[tyler36]

Before the move to ddev domain, the scheduled tests were failing.

...
# failed to solve: failed to compute cache key: "/cron.conf" not found: not found
# Failed to restart ddev-cron: ComposeCmd failed to run 'COMPOSE_PROJECT_NAME=ddev-ddev-cron docker-compose -f /home/runner/tmp/ddev-cron/.ddev/.ddev-docker-compose-full.yaml up --build -d', action='[up --build -d]', err='exit status 17', stdout='#1 [drud/ddev-dbserver-mariadb-10.4:v1.21.4-ddev-cron-built internal] load build definition from Dockerfile
...

a4f86f1 was an attempt to fix it, however, tests still fail.

Unable to replicate issue locally; all tests pass

Test

bats ./tests/test.bats     
test.bats
 ✓ install from directory
   ddev started at Wed Feb  8 08:49:56 JST 2023
   ddev get /home/user13/code/pr/ddev-cron/tests/.. with project ddev-cron in /home/user13/tmp/ddev-cron (/home/user13/tmp/ddev-cron)
 ✓ install from release
   ddev started at Wed Feb  8 08:51:40 JST 2023
   ddev get drud/ddev-cron with project ddev-cron in /home/user13/tmp/ddev-cron (/home/user13/tmp/ddev-cron)

2 tests, 0 failures

[rfay]

I'll try to see if I can understand it tomorrow.

[rfay]

I get this easily when I do this with current DDEV HEAD:

ddev get drud/ddev-cron
ddev start


Starting d9...
Network ddev_default created
failed to solve: failed to compute cache key: "/cron.conf" not found: not found
Failed to start d9: ComposeCmd failed to run 'COMPOSE_PROJECT_NAME=ddev-d9 docker-compose -f /Users/rfay/workspace/d9/.ddev/.ddev-docker-compose-full.yaml up --build -d', action='[up --build -d]', err='exit status 17', stdout='#1 [drud/ddev-dbserver-mariadb-10.6:v1.21.4-d9-built internal] load build definition from Dockerfile
#1 transferring dockerfile: 755B done
#1 DONE 0.0s

#2 [drud/ddev-webserver:20230207_fix_nvm-d9-built internal] load build definition from Dockerfile
#2 transferring dockerfile: 1.63kB done
#2 DONE 0.0s

#3 [drud/ddev-webserver:20230207_fix_nvm-d9-built internal] load .dockerignore
#3 transferring context: 2B done
#3 DONE 0.0s

#4 [drud/ddev-dbserver-mariadb-10.6:v1.21.4-d9-built internal] load .dockerignore
#4 transferring context: 2B done
#4 DONE 0.0s

#5 [drud/ddev-webserver:20230207_fix_nvm-d9-built internal] load metadata for docker.io/drud/ddev-webserver:20230207_fix_nvm
#5 DONE 0.0s

#6 [drud/ddev-dbserver-mariadb-10.6:v1.21.4-d9-built internal] load metadata for docker.io/drud/ddev-dbserver-mariadb-10.6:v1.21.4
#6 DONE 0.0s

#7 [drud/ddev-webserver:20230207_fix_nvm-d9-built 1/8] FROM docker.io/drud/ddev-webserver:20230207_fix_nvm
#7 DONE 0.0s

#8 [drud/ddev-dbserver-mariadb-10.6:v1.21.4-d9-built 1/3] FROM docker.io/drud/ddev-dbserver-mariadb-10.6:v1.21.4
#8 DONE 0.0s

#9 [drud/ddev-dbserver-mariadb-10.6:v1.21.4-d9-built 2/3] RUN (groupadd --gid 20 "rfay" || groupadd "rfay" || true) && (useradd  -l -m -s "/bin/bash" --gid "rfay" --comment '' --uid 501 "rfay" || useradd  -l -m -s "/bin/bash" --gid "rfay" --comment '' "rfay" || useradd  -l -m -s "/bin/bash" --gid "20" --comment '' "rfay" || useradd -l -m -s "/bin/bash" --comment '' rfay )
#9 CACHED

#10 [drud/ddev-dbserver-mariadb-10.6:v1.21.4-d9-built 3/3] RUN echo "Built on $(date)" > /build-date.txt
#10 CACHED

#11 [drud/ddev-webserver:20230207_fix_nvm-d9-built 4/8] RUN export XDEBUG_MODE=off; composer self-update --stable || composer self-update --stable || true; composer self-update --2 || composer self-update --2 || true
#11 CACHED

#12 [drud/ddev-webserver:20230207_fix_nvm-d9-built 2/8] RUN (groupadd --gid 20 "rfay" || groupadd "rfay" || true) && (useradd  -l -m -s "/bin/bash" --gid "rfay" --comment '' --uid 501 "rfay" || useradd  -l -m -s "/bin/bash" --gid "rfay" --comment '' "rfay" || useradd  -l -m -s "/bin/bash" --gid "20" --comment '' "rfay" || useradd -l -m -s "/bin/bash" --comment '' rfay )
#12 CACHED

#13 [drud/ddev-webserver:20230207_fix_nvm-d9-built 3/8] RUN ls -lR >/dev/null
#13 CACHED

#14 [drud/ddev-webserver:20230207_fix_nvm-d9-built 5/8] RUN mkdir -p /home/rfay && chown rfay /home/rfay && chmod 600 /home/rfay/.pgpass
#14 CACHED

#15 [drud/ddev-webserver:20230207_fix_nvm-d9-built internal] load build context
#15 transferring context: 2B done
#15 DONE 0.0s

#16 [drud/ddev-webserver:20230207_fix_nvm-d9-built 7/8] ADD cron.conf /etc/supervisor/conf.d
#16 ERROR: "/cron.conf" not found: not found

#17 [drud/ddev-dbserver-mariadb-10.6:v1.21.4-d9-built] exporting to image
#17 exporting layers done
#17 writing image sha256:09a5eafa609b423a7ad7a96b0970b7bea89dfbc6b9640ee16c34a8ef6259c046 done
#17 naming to docker.io/drud/ddev-dbserver-mariadb-10.6:v1.21.4-d9-built done
#17 DONE 0.0s

#18 [drud/ddev-webserver:20230207_fix_nvm-d9-built 6/8] RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y -o Dpkg::Options::="--force-confold" --no-install-recommends --no-install-suggests cron
#18 CANCELED
------
 > [drud/ddev-webserver:20230207_fix_nvm-d9-built 7/8] ADD cron.conf /etc/supervisor/conf.d:
------
', stderr='failed to solve: failed to compute cache key: "/cron.conf" not found: not found'

[rfay]

Ah, the problem is that the context in latest HEAD has changed. The release/deployment notes in ddev/ddev#4549 "mention" this but it's not very clear.

In latest DDEV head, the location of cron.conf will be .ddev/web-build/cron.conf

So

ADD cron.conf /etc/supervisor/conf.d

changes to

ADD .ddev/web-build/cron.conf /etc/supervisord/conf.d

Please make sure I get this right in the release notes when v1.21.5 comes out!

Now the question is... how does the add-on handle this?

[rfay]

A post-start action in the install.yaml could add to the Dockerfile.cron based on the version...
ddev debug capabilities shows web-start-hooks if this feature exists.

[rfay]

The huge win here is TESTS FTW! The check against HEAD pointed out the problem before it impacted users.

[tyler36]

The huge win here is TESTS FTW! The check against HEAD pointed out the problem before it impacted users.

Exactly. Testing against current stable and latest HEAD really helps catch these issues. And allows time for solutions and workarounds.