Skip to content

Conversation

@tyler36
Copy link
Collaborator

@tyler36 tyler36 commented Jun 13, 2023

The Issue

I recieve notifications of failed tests on my local fork of this project.
These do not appear on this upstream repo.

gautamkrishnar/keepalive-workflow#14

How This PR Solves The Issue

Adds permissions as suggested by upstream.

Manual Testing Instructions

Automated Testing Overview

Related Issue Link(s)

If we want to encourage people to fork and contribute, this PR helps eliminate false positives when running tests.

Release/Deployment Notes

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the notifications thing is related to the permissions. I haven't ever sorted that out exactly. I'm not sure who gets notified; seems the actual owner (probably me?) always gets notifications.

In this case though, the tests haven't been misbehaving, right?

@tyler36
Copy link
Collaborator Author

tyler36 commented Jun 13, 2023

After my initial repo was move to DDEV, I forked this repo to make PRs.
This repo's scheduled tests are passing.

My forked repo started failing last week with the error, so it sends notifications when those tests fail. If the fix is to add the permissions, then doing this upstream (here) will prevent other forks from also failing.

I'm not sure if this is the correct fix though.

@rfay
Copy link
Member

rfay commented Jun 13, 2023

So you think this problem has to do with whether or not a project is a fork?

@tyler36
Copy link
Collaborator Author

tyler36 commented Jun 13, 2023

Looking at the action logs:

  • 2023-6-6 16:14 - tyler36/ddev-cron has first failed test. Continues failing everyday.
  • 2023-6-6 16:24 - ddev/ddev-cron has keepalive dummy commit. Continues passing everyday.

I just manually merged my fork with ddev/ddev-cron so it should be quiet for a while.

@tyler36
Copy link
Collaborator Author

tyler36 commented Jul 7, 2023

@tyler36 tyler36 merged commit cfd4a81 into ddev:main Jul 7, 2023
@tyler36 tyler36 deleted the fix_permissions_for_keepalive branch July 7, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants