Move to Dockerfile installation

[tyler36]

Fixes #31

[rfay]

This is awesome. A few problems with copy-pasta, but it's great.

The overall problem of how to manage custom configuration without breaking future ddev get ddev/ddev-cron and also making ddev get --remove work successfully has possibilities. In add-ons I've been using unmanaged files (non-#ddev-generated) like docker-compose.redis-extra.yaml for example as overrides. Not sure how easy that is to do here but I think you'll get it.

[tyler36]

Wow ... Not sure where my head was that day. Sorry for the low quality.

[tyler36]

Did some research and had a rethink.

• No default job is present OOTB
• Update now allows multiple *.cron jobs
• Examples updated to show specific steps.

[tyler36]

I suspect the "install from release" test are failing because they don't the content from this PR, no?

[rfay]

Yes, you can either ignore the "install from release" tests or temporarily disable them.

[rfay]

Test with

ddev get https://github.com/tyler36/ddev-cron/tarball/issue31_Move-to-Dockerfile-installation

[rfay]

I tried this out and it looks great. Some suggestions along the way.

• I think it would be good to add info about timezone: configuration here because people will get confused about what time things happen without that
• Mentioning ddev exec crontab -l may help people to see what's configured.

[tyler36]

OK ... merged the suggested changes.

Also fixed the issue with running multiple jobs so should be OK now.

[rfay]

OH, now I remember why IS_DDEV_PROJECT is critical in the context of cron. Cron doesn't pass any environment variables along. So for any CMS type that has DDEV-generated settings, like Drupal or TYPO3 but probably not Laravel? the settings won't be executed without it. Sorry for forgetting this.

[tyler36]

Thanks. I thinks that everything now, or did I miss something?

[rfay]

Several suggestions didn't get committed or discussed, please return to those.

The one thing that might make it easier for people would be to provide the main examples as examples in the .ddev/web-build. Maybe the drupal and typo3 examples, for example, just like you do with the simple time log.

Thanks for this!

[tyler36]

Mentioning ddev exec crontab -l may help people to see what's configured.

I replace crontab -e with crontab -l in the example. -e asks about selecting an editor, -l simply outputs the contents

[rfay]

Sorry, we're getting lost here, and the review page is getting too cluttered and I get lost in it now.

Here's what the README has right now:
https://github.com/ddev/ddev-cron/blob/642fe9ab2c94cfd4ad7f2ac0d5e3c40575954c58/README.md

This is one of the things I was trying to get rid of because I don't believe people will ever need to edit it:

Other than thinking we shouldn't confuse people with that one, I think everything is fine to go.

Sorry it's been so difficult to get through this, but I sure appreciate this good work.

[tyler36]

Appologies for the very messy work flow on this. The VSCode extension seemed inconsistent on this repo. And my fingers were too fat at other times.

[rfay]

Thanks, looking great. Pull when you're ready.

I don't think that github "Files changed" page was helping us much. It got all messy and you couldn't tell what was where.

[tyler36]

Thank you.

We got there in the end.

[tyler36]

All tests from this PR passed after merge and 1.5.0 (which included this) was released.