Add health check clarification #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
With this setup and the way it works you can probably just check to see that some lines have been added to the test output file maybe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some testing comments.
Background
In the DDEV Testing Infrastructure live training, @rfay browsed to this repo as an example of testing addons. At quick glance, he was suprised at the lightweight health check used.
Due to the re-write in #35, an addional test was needed to ensure the service ran when there are no jobs. I decided to re-use the same health check to ensure consistency. However, this meant the actual implented job check would need to be extracted.
Or do we need a better "health_checks" check?